Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s libs to 1.30.x #2649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Aug 9, 2024

Supersedes #2626

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.35%. Comparing base (fcba408) to head (1db3286).

Files Patch % Lines
controllers/appsv1/deployment_webhook.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files         124      124           
  Lines        8525     8525           
=======================================
  Hits         6424     6424           
  Misses       1904     1904           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

the CI fails on

The CustomResourceDefinition "jaegers.jaegertracing.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

Do not merge this PR. The large CRD cannot be installe with k apply -f I will try to find a better approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants